Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to system.text for c# #221

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Change to system.text for c# #221

merged 3 commits into from
Sep 8, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 8, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Quicktype now supports System.Text.Json which we typically prefer over Newtonsoft when possible. I also changed settings to only require partial inputs.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia September 8, 2023 09:49
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 8, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 08f44b02-9e2f-41a1-aaff-38847d823aef

No New Or Fixed Issues Found

@Hinton Hinton merged commit 7196a66 into master Sep 8, 2023
39 checks passed
@Hinton Hinton deleted the ps/system-text branch September 8, 2023 10:24
@Hinton Hinton mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia