Fix make_user_key which previously didn't stretch the users key #315

Hinton · 2023-10-31T09:49:28Z

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The make_user_key needs to use the same key as decrypt_user_key, which should be the stretched users key.

Before you submit

Please add unit tests where it makes sense to do so (encouraged but not required)

bitwarden-bot · 2023-10-31T09:52:00Z

Checkmarx One – Scan Summary & Details – 9e6b3f2b-75da-4605-a74e-f4237b02069e

No New Or Fixed Issues Found

Fix make_user_key which previously didn't stretch the users key

d085236

Add some unit tests

77d0f75

Hinton requested a review from dani-garcia October 31, 2023 10:37

Hinton added 2 commits October 31, 2023 11:43

Move test to integration test

ff3ff60

Switch to use rand_chacha

6d30c26

dani-garcia approved these changes Oct 31, 2023

View reviewed changes

dani-garcia merged commit 1c86c09 into master Nov 1, 2023
45 checks passed

dani-garcia deleted the ps/fix-make-user-key branch November 1, 2023 11:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix make_user_key which previously didn't stretch the users key #315

Fix make_user_key which previously didn't stretch the users key #315

Hinton commented Oct 31, 2023

bitwarden-bot commented Oct 31, 2023 •

edited

Loading

Fix make_user_key which previously didn't stretch the users key #315

Fix make_user_key which previously didn't stretch the users key #315

Conversation

Hinton commented Oct 31, 2023

Type of change

Objective

Before you submit

bitwarden-bot commented Oct 31, 2023 • edited Loading

No New Or Fixed Issues Found

bitwarden-bot commented Oct 31, 2023 •

edited

Loading