-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1086] Improve TS bindings #398
Conversation
No New Or Fixed Issues Found |
98e2c07
to
76b3e87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage ? 57.76%
=======================================
Files ? 168
Lines ? 9912
Branches ? 0
=======================================
Hits ? 5726
Misses ? 4186
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This should probably go through SM review and QA process before merging. From a quick glance it looks to follow the other language bindings. @coltonhurst do we want to look into deprecating the napi bindings and swap to the wasm for gh actions? |
Sorry for the delayed response. Yes, I think that would be a good thing to take care of, I can create an internal ticket for this. The work deprecating the napi bindings and swapping to wasm for gh actions shouldn't block this PR though, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, only other thing I can think of is to add a readme to the languages/js directory that helps explain how to build and run the example project, kind of like we have in the other language directories. Still approved though!
(The ruby one also has a changelog file, which might be beneficial, but that could also wait until we do a release.)
Type of change
Objective
Implement support for projects, accesstokenlogin and response unwrapping. Also added a small example