Implement KeyEncryptable support for Asymmetric keys #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 49.51% 50.04% +0.53%
==========================================
Files 154 155 +1
Lines 7398 7467 +69
==========================================
+ Hits 3663 3737 +74
+ Misses 3735 3730 -5 ☔ View full report in Codecov by Sentry. |
Hinton
reviewed
Dec 18, 2023
Hinton
reviewed
Dec 18, 2023
Hinton
reviewed
Dec 18, 2023
dani-garcia
added a commit
that referenced
this pull request
Dec 19, 2023
## Type of change ``` - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective Split `EncString` into an asymmetric variant. I've left the symmetric variant with the name `EncString` as it's the most common variant to avoid major changes. This is somewhat related to #447 and should be merged first so that PR can take advantage of the symm/asymm separation. I've moved the `EncString` files into their own folder to organize the crypto directory a bit better too.
# Conflicts: # crates/bitwarden/src/client/encryption_settings.rs # crates/bitwarden/src/crypto/enc_string/symmetric.rs
# Conflicts: # crates/bitwarden/src/client/encryption_settings.rs
Hinton
reviewed
Jan 8, 2024
…ot needed anymore
# Conflicts: # crates/bitwarden/src/crypto/symmetric_crypto_key.rs
# Conflicts: # crates/bitwarden/src/crypto/enc_string/asymmetric.rs # crates/bitwarden/src/crypto/symmetric_crypto_key.rs
Hinton
previously approved these changes
Jan 11, 2024
# Conflicts: # crates/bitwarden/src/crypto/symmetric_crypto_key.rs
Hinton
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Implement KeyEncryptable support for Asymmetric keys.