Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lib architectures in language SDKs #498

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Fix lib architectures in language SDKs #498

merged 5 commits into from
Jan 18, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 12, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

  • Rename ubuntu-x64 to linux-x64 to better match the usage.
  • Resolve java using the wrong prefixes. It should be x86_64 for architecture, and windows should use win32.

Resolves #491

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from a team as a code owner January 12, 2024 11:33
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c91270) 50.04% compared to head (d9a715d) 50.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files         155      155           
  Lines        7467     7467           
=======================================
  Hits         3737     3737           
  Misses       3730     3730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from a team January 12, 2024 11:37
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hinton Hinton merged commit 8b435e5 into main Jan 18, 2024
42 checks passed
@Hinton Hinton deleted the ps/fix-arch branch January 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong host architectures for Java bindings (darwin-x64 -> darwin-x86-64) and others as well
3 participants