Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure we are using a compatible rustls version #569

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

dani-garcia
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We need to keep the version of rustls that reqwest and rustls-platform-verifier use in sync to avoid runtime errors when creating the reqwest client, we can't check it at compile time due to the use of &dyn Any and downcasting, but we can add a test.

@dani-garcia dani-garcia requested a review from Hinton February 1, 2024 12:36
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details3a2f63ff-414c-49a3-9d1f-e967b8bf0dd1

No New Or Fixed Issues Found

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (872a05b) 52.75% compared to head (98eed04) 52.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   52.75%   52.84%   +0.09%     
==========================================
  Files         163      163              
  Lines        8381     8397      +16     
==========================================
+ Hits         4421     4437      +16     
  Misses       3960     3960              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit ac58ac9 into main Feb 2, 2024
57 checks passed
@dani-garcia dani-garcia deleted the ps/test-rustls-compatible branch February 2, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants