Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more tests for Crypto crate #570

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Write more tests for Crypto crate #570

merged 4 commits into from
Feb 1, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 1, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Extend unit testing for the crypto crate.

Before you submit

  • Please add unit tests where it makes sense to do so

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 1, 2024

Logo
Checkmarx One – Scan Summary & Detailse4d86989-bf90-41c1-8aae-b5d83a3666d9

No New Or Fixed Issues Found

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (872a05b) 52.75% compared to head (953da67) 54.02%.

Files Patch % Lines
...rates/bitwarden-crypto/src/enc_string/symmetric.rs 97.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   52.75%   54.02%   +1.27%     
==========================================
  Files         163      163              
  Lines        8381     8520     +139     
==========================================
+ Hits         4421     4603     +182     
+ Misses       3960     3917      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Write more tests for Asymmetric Write more tests for Crypto crate Feb 1, 2024
@Hinton Hinton marked this pull request as ready for review February 1, 2024 15:00
@Hinton Hinton requested a review from dani-garcia February 1, 2024 15:00
@Hinton Hinton merged commit 6749058 into main Feb 1, 2024
58 checks passed
@Hinton Hinton deleted the ps/crypto-tests branch February 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants