Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps]: Update prettier to v3.2.5 #583

Merged
merged 3 commits into from
Feb 5, 2024
Merged

[deps]: Update prettier to v3.2.5 #583

merged 3 commits into from
Feb 5, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 4, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 3.2.4 -> 3.2.5 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.2.5

Compare Source

diff

Support Angular inline styles as single template literal (#​15968 by @​sosukesuzuki)

Angular v17 supports single string inline styles.

// Input
@​Component({
  template: `<div>...</div>`,
  styles: `h1 { color: blue; }`,
})
export class AppComponent {}

// Prettier 3.2.4
@&#8203;Component({
  template: `<div>...</div>`,
  styles: `h1 { color: blue; }`,
})
export class AppComponent {}

// Prettier 3.2.5
@&#8203;Component({
  template: `<div>...</div>`,
  styles: `
    h1 {
      color: blue;
    }
  `,
})
export class AppComponent {}
Unexpected embedded formatting for Angular template (#​15969 by @​JounQin)

Computed template should not be considered as Angular component template

// Input
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{       hello }}</h1>`,
})
export class AppComponent {}

// Prettier 3.2.4
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{ hello }}</h1>`,
})
export class AppComponent {}

// Prettier 3.2.5
const template = "foobar";

@&#8203;Component({
  [template]: `<h1>{{       hello }}</h1>`,
})
export class AppComponent {}
Use "json" parser for tsconfig.json by default (#​16012 by @​sosukesuzuki)

In v2.3.0, we introduced "jsonc" parser which adds trialing comma by default.

When adding a new parser we also define how it will be used based on the linguist-languages data.

tsconfig.json is a special file used by TypeScript, it uses .json file extension, but it actually uses the JSON with Comments syntax. However, we found that there are many third-party tools not recognize it correctly because of the confusing .json file extension.

We decide to treat it as a JSON file for now to avoid the extra configuration step.

To keep using the "jsonc" parser for your tsconfig.json files, add the following to your .pretterrc file

{
  "overrides": [
    {
      "files": ["tsconfig.json", "jsconfig.json"],
      "options": {
        "parser": "jsonc"
      }
    }
  ]
}

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@bitwarden-bot bitwarden-bot changed the title [deps]: Update prettier to v3.2.5 [PM-6063] [deps]: Update prettier to v3.2.5 Feb 4, 2024
@bitwarden-bot
Copy link

bitwarden-bot commented Feb 4, 2024

Logo
Checkmarx One – Scan Summary & Details9d2a1ab9-db3e-49b9-b581-7ca9c0b51cc6

No New Or Fixed Issues Found

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ddd9888) 53.77% compared to head (a02eaa1) 53.77%.
Report is 5 commits behind head on main.

❗ Current head a02eaa1 differs from pull request most recent head 0ed1e82. Consider uploading reports for the commit 0ed1e82 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   53.77%   53.77%           
=======================================
  Files         165      165           
  Lines        8878     8878           
=======================================
  Hits         4774     4774           
  Misses       4104     4104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title [PM-6063] [deps]: Update prettier to v3.2.5 [deps]: Update prettier to v3.2.5 Feb 4, 2024
@renovate renovate bot force-pushed the renovate/prettier-3.x branch 4 times, most recently from 013b50b to af351e8 Compare February 5, 2024 10:42
@renovate renovate bot force-pushed the renovate/prettier-3.x branch from af351e8 to def8135 Compare February 5, 2024 10:43
@Hinton Hinton requested a review from dani-garcia February 5, 2024 12:42
Copy link
Contributor Author

renovate bot commented Feb 5, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@Hinton Hinton merged commit 43bdcf0 into main Feb 5, 2024
55 checks passed
@Hinton Hinton deleted the renovate/prettier-3.x branch February 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants