SM-1098: Update Python Wrapper README Instructions #592
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 59.43% 59.43%
=======================================
Files 171 171
Lines 10320 10320
=======================================
Hits 6134 6134
Misses 4186 4186 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
| @@ -31,5 +32,8 @@ pip install bitwarden-sdk | |||
| Set the `ORGANIZATION_ID` and `ACCESS_TOKEN` environment variables to your organization ID and access token, respectively. | |||
|
|
|||
| ```bash | |||
| source .venv/bin/activate | |||
There was a problem hiding this comment.
This is under run and we do not know if they use a venv or some other approach.
There was a problem hiding this comment.
Moved this to a Using Virtual Environments section, away from the Run section. If anything, it will hopefully help those who are less familiar with Python get started.
languages/python/README.md
Outdated
| @@ -12,6 +12,7 @@ From the root of the repository: | |||
| npm run schemas # generate schemas.py | |||
|
|
|||
| cd languages/python/ | |||
| python3 -m venv .venv | |||
There was a problem hiding this comment.
Should we move this under virtual env? This command doesn't mount the venv either.
There was a problem hiding this comment.
Moved everything to the separate section for running & building with virtual environments here:
Type of change
Objective
Update the Python Wrapper README, now that we are using maturin.