Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get-by-ids to Go wrapper #620

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

tangowithfoxtrot
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Allow secret fetching by a list of IDs, rather than requesting multiple secrets individually. Exposes the functionality from #150 in Go.

Code changes

  • languages/go/secrets.go: Add GetByIDS func.
  • languages/go/example/example.go: Get secrets by ID. Added JSON output for QA/ease-of-use.

@tangowithfoxtrot tangowithfoxtrot requested review from a team, dani-garcia and Hinton February 20, 2024 17:54
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff94313) 59.40% compared to head (749923f) 59.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         171      171           
  Lines       10345    10345           
=======================================
  Hits         6145     6145           
  Misses       4200     4200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 20, 2024

Logo
Checkmarx One – Scan Summary & Detailsdb80aecf-acfc-49b4-829f-8c932cab01bd

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Denial_Of_Service_Resource_Exhaustion /languages/go/example/example.go: 16 Attack Vector
MEDIUM Denial_Of_Service_Resource_Exhaustion /languages/go/example/example.go: 21 Attack Vector
MEDIUM Denial_Of_Service_Resource_Exhaustion /languages/go/example/example.go: 15 Attack Vector
MEDIUM Privacy_Violation /languages/go/example/example.go: 103 Attack Vector
MEDIUM Privacy_Violation /languages/go/example/example.go: 103 Attack Vector

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangowithfoxtrot tangowithfoxtrot merged commit e16cea0 into main Feb 29, 2024
60 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the sm/SM-1128/add-get-by-ids-to-go-wrapper branch February 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants