fix: linux arm64 cross-compilation (hopefully) #653
Conversation
|
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 60.53% 60.61% +0.07%
==========================================
Files 172 170 -2
Lines 10527 10387 -140
==========================================
- Hits 6373 6296 -77
+ Misses 4154 4091 -63 ☔ View full report in Codecov by Sentry. |
| - name: Build Rust | ||
| env: | ||
| RUSTFLAGS: "-D warnings" | ||
| if: ${{ matrix.settings.target }} == aarch64-unknown-linux-gnu | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y crossbuild-essential-arm64 | ||
| cargo build --target ${{ matrix.settings.target }} --release | ||
|
|
There was a problem hiding this comment.
Use cross for this, that's what we do in the other workflows.
There was a problem hiding this comment.
I haven't been able to build with cross for that target locally. I end up getting an error from the linker that it's unable to link something, so I end up having to build in a Linux ARM64 VM.
Oddly though, I'm not even getting that far in the workflow runner with cross. It fails when trying to build the ring crate. Any idea how to get past that?
There was a problem hiding this comment.
Actually, looking at this, cross apparently doesn't have the right build tools installed? I thought cross pulled a container image that was configured for whatever target you specified.
There was a problem hiding this comment.
That's not running through cross, you need to swap out the cargo command for cross, look at the other workflows for examples.
Type of change
Objective
Code changes
Before you submit