Skip to content

Commit

Permalink
rename Python package to bitwarden_sdk (#399)
Browse files Browse the repository at this point in the history
## Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [x] Other

## Objective

Rename the Python package. This should be merged before #369. 

## Code changes

- **`languages/python/setup.py`:** Rename package
- **`languages/python/bitwarden_sdk`:** Rename directory to match
package name
- **`.gitignore`:** Changed path to `schemas.py`
- **`.github/workflows/generate_schemas.yml`:** Changed path to
`schemas.py`

## Before you submit

- Please add **unit tests** where it makes sense to do so (encouraged
but not required)
  • Loading branch information
tangowithfoxtrot authored Dec 6, 2023
1 parent 327cbb8 commit 7ececc5
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/generate_schemas.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: schemas.py
path: ${{ github.workspace }}/languages/python/BitwardenClient/schemas.py
path: ${{ github.workspace }}/languages/python/bitwarden_sdk/schemas.py
if-no-files-found: error

- name: Upload ruby schemas artifact
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ support/schemas
crates/bitwarden-napi/src-ts/bitwarden_client/schemas.ts
languages/csharp/Bitwarden.Sdk/schemas.cs
languages/js_webassembly/bitwarden_client/schemas.ts
languages/python/BitwardenClient/schemas.py
languages/python/bitwarden_sdk/schemas.py
languages/cpp/include/schemas.hpp
languages/go/schema.go
languages/java/src/main/java/com/bitwarden/sdk/schema
File renamed without changes.
4 changes: 2 additions & 2 deletions languages/python/example.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import json
import logging
import sys
from BitwardenClient.bitwarden_client import BitwardenClient
from BitwardenClient.schemas import client_settings_from_dict, DeviceType
from bitwarden_sdk.bitwarden_client import BitwardenClient
from bitwarden_sdk.schemas import client_settings_from_dict, DeviceType

# Create the BitwardenClient, which is used to interact with the SDK
client = BitwardenClient(client_settings_from_dict({
Expand Down
4 changes: 2 additions & 2 deletions languages/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
from setuptools_rust import Binding, RustExtension

setup(
name="BitwardenClient",
name="bitwarden_sdk",
description="A Bitwarden Client for python",
version="0.1",
rust_extensions=[RustExtension(
"bitwarden_py", path="../../crates/bitwarden-py/Cargo.toml", binding=Binding.PyO3)],
packages=['bitwardenclient'],
packages=['bitwarden_sdk'],
zip_safe=False,
)

0 comments on commit 7ececc5

Please sign in to comment.