Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ps/flatten error #1132

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Ps/flatten error #1132

wants to merge 2 commits into from

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Oct 11, 2024

🎟️ Tracking

📔 Objective

Experiment with macros

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Logo
Checkmarx One – Scan Summary & Detailse64e6b17-dffb-419a-8a8e-ed81723d913d

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /publish-napi.yml: 111
MEDIUM Unpinned Actions Full Length Commit SHA /release-go.yml: 89
MEDIUM Unpinned Actions Full Length Commit SHA /release-ruby.yml: 51
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 86
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 173
MEDIUM Unpinned Actions Full Length Commit SHA /publish-java.yml: 99
MEDIUM Unpinned Actions Full Length Commit SHA /build-ruby.yml: 25
MEDIUM Unpinned Actions Full Length Commit SHA /release-wasm.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /publish-internal.yml: 62
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 54
MEDIUM Unpinned Actions Full Length Commit SHA /publish-java.yml: 83
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 52
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 74
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 131
MEDIUM Unpinned Actions Full Length Commit SHA /release-dotnet.yml: 54
MEDIUM Unpinned Actions Full Length Commit SHA /publish-dotnet.yml: 88
MEDIUM Unpinned Actions Full Length Commit SHA /release-bws.yml: 44
MEDIUM Unpinned Actions Full Length Commit SHA /publish-wasm.yml: 87
MEDIUM Unpinned Actions Full Length Commit SHA /release-cpp.yml: 65
MEDIUM Unpinned Actions Full Length Commit SHA /publish-php.yml: 177
MEDIUM Unpinned Actions Full Length Commit SHA /release-napi.yml: 45
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 163
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli-docker.yml: 61
MEDIUM Unpinned Actions Full Length Commit SHA /publish-rust-crates.yml: 77
MEDIUM Unpinned Actions Full Length Commit SHA /publish-internal.yml: 68
MEDIUM Unpinned Actions Full Length Commit SHA /publish-ruby.yml: 92
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 93
MEDIUM Unpinned Actions Full Length Commit SHA /build-swift.yml: 96
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 54
MEDIUM Unpinned Actions Full Length Commit SHA /publish-python.yml: 108
MEDIUM Unpinned Actions Full Length Commit SHA /release-go.yml: 69
MEDIUM Unpinned Actions Full Length Commit SHA /release-swift.yml: 137
MEDIUM Unpinned Actions Full Length Commit SHA /publish-php.yml: 90
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 338
MEDIUM Unpinned Actions Full Length Commit SHA /publish-bws.yml: 169
MEDIUM Unpinned Actions Full Length Commit SHA /release-cpp.yml: 59

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.23%. Comparing base (8b44f55) to head (fee85ce).

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/error.rs 0.00% 10 Missing ⚠️
...s/bitwarden-core/src/client/encryption_settings.rs 0.00% 1 Missing ⚠️
crates/bitwarden-error-macro/src/lib.rs 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
+ Coverage   58.17%   58.23%   +0.05%     
==========================================
  Files         197      198       +1     
  Lines       13587    13632      +45     
==========================================
+ Hits         7904     7938      +34     
- Misses       5683     5694      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroiu coroiu marked this pull request as draft October 11, 2024 15:03
Base automatically changed from ps/generic-wasm-error-alternative to PM-11764-implement-account-switching-and-sdk-initialization October 14, 2024 09:56
Base automatically changed from PM-11764-implement-account-switching-and-sdk-initialization to main October 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant