[BEEEP] - Docker image for bws
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
|
Addresses Checkmarx warning.
tangowithfoxtrot
changed the title
bwsbws
michalchecinski
requested changes
Oct 30, 2023
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
michalchecinski
previously requested changes
Oct 30, 2023
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Co-authored-by: Michał Chęciński <mchecinski@bitwarden.com>
Hinton
reviewed
Oct 31, 2023
Hinton
reviewed
Oct 31, 2023
tangowithfoxtrot
dismissed
michalchecinski’s stale review
Dockerfile was moved to ./crates/bws
vgrassia
requested changes
Nov 2, 2023
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Hinton
reviewed
Nov 19, 2023
vgrassia
previously requested changes
Nov 20, 2023
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
michalchecinski
previously approved these changes
Nov 30, 2023
There was a problem hiding this comment.
LGTM. @vgrassia since you added few suggestions please also check if everything is good for you 😃
tangowithfoxtrot
dismissed
vgrassia’s stale review
additional target architectures don't compile
vgrassia
previously approved these changes
Jan 10, 2024
tangowithfoxtrot
dismissed stale reviews from vgrassia and michalchecinski
via
e0870a6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 154 154
Lines 7398 7398
=======================================
Hits 3663 3663
Misses 3735 3735 ☔ View full report in Codecov by Sentry. |
vgrassia
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Add a
bwsDockerfile.Objective
This allows us to publish a
bitwarden/bwsdocker image. Multi-arch images can be built with the following command:docker buildx build -f ./crates/bws/Dockerfile --push -t bitwarden/bws --platform linux/amd64,linux/arm64 .Code changes
Dockerfile: add fileBefore you submit