-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BRE-101] Remove dept-devops from CODEOWNERS #826
[BRE-101] Remove dept-devops from CODEOWNERS #826
Conversation
Hold untill https://bitwarden.atlassian.net/servicedesk/customer/portal/5/TSD-648 done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 58.18% 58.17% -0.02%
==========================================
Files 197 197
Lines 13584 13587 +3
==========================================
Hits 7904 7904
- Misses 5680 5683 +3 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
Thanks @mzieniukbw! Didn't know multiple teams can go into one line. |
.github/CODEOWNERS
Outdated
.github/workflows/build-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev | ||
.github/workflows/build-python-wheels.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev | ||
.github/workflows/build-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev | ||
.github/workflows/build-rust-crates.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is listed in the ## Multiple owners
section below as well. Could you delete one of the entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Removed it from here, as this workflow is not only owned by SM dev.
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-101
📔 Objective
Remove dept-devops from CODEOWNERS and add
bitwarden/dept-bre
for all release workflows.📸 Screenshots
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes