Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-101] Remove dept-devops from CODEOWNERS #826

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

michalchecinski
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-101

📔 Objective

Remove dept-devops from CODEOWNERS and add bitwarden/dept-bre for all release workflows.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@michalchecinski michalchecinski added the hold do not merge, do not approve yet label Jun 10, 2024
@michalchecinski
Copy link
Contributor Author

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.17%. Comparing base (d094901) to head (93e0331).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   58.18%   58.17%   -0.02%     
==========================================
  Files         197      197              
  Lines       13584    13587       +3     
==========================================
  Hits         7904     7904              
- Misses       5680     5683       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 10, 2024

Logo
Checkmarx One – Scan Summary & Detailsdadf87bb-7234-426e-8dc3-5cd8d196696a

Fixed Issues

Severity Issue Source File / Package
MEDIUM Missing_HSTS_Header /languages/php/example.php: 3
MEDIUM Parameter_Tampering /languages/kotlin/app/src/main/java/com/bitwarden/myapplication/MainActivity.kt: 384
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/example/Example.java: 46
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/BitwardenClient.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 41
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 138
MEDIUM Privacy_Violation /languages/java/example/Example.java: 43
MEDIUM Privacy_Violation /languages/java/src/main/java/com/bitwarden/sdk/SecretsClient.java: 20
MEDIUM Privacy_Violation /languages/java/example/Example.java: 53
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/Secrets.cpp: 56
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/Secrets.cpp: 139
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 122
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 115
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/Secrets.cpp: 107
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 159
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 136
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 122
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 151
LOW Privacy_Violation /languages/cpp/src/BitwardenClient.cpp: 129

@michalchecinski michalchecinski requested review from vgrassia, Hinton and a team October 15, 2024 12:13
@michalchecinski michalchecinski removed the hold do not merge, do not approve yet label Oct 15, 2024
@michalchecinski
Copy link
Contributor Author

@Hinton @bitwarden/team-secrets-manager @vgrassia Please check the codeowners file as there are a lot of workflows in the repo and the ownership can fluctuate.

.github/CODEOWNERS Outdated Show resolved Hide resolved
michalchecinski and others added 2 commits October 15, 2024 16:58
Co-authored-by: Maciej Zieniuk <167752252+mzieniukbw@users.noreply.github.com>
@michalchecinski
Copy link
Contributor Author

Thanks @mzieniukbw! Didn't know multiple teams can go into one line.

.github/workflows/build-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-python-wheels.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-rust-crates.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is listed in the ## Multiple owners section below as well. Could you delete one of the entries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Removed it from here, as this workflow is not only owned by SM dev.

.github/CODEOWNERS Outdated Show resolved Hide resolved
michalchecinski and others added 2 commits October 17, 2024 11:35
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
@michalchecinski michalchecinski merged commit 37b22fe into main Oct 17, 2024
98 of 99 checks passed
@michalchecinski michalchecinski deleted the BRE-101-Remove-dept-devops-from-CODEOWNERS branch October 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants