Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-139] - Clean Up Extra Spaces to Test CD Workflow #25

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Nov 5, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/BRE-410

๐Ÿ“” Objective

  • PR to test CD worklfow

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner November 5, 2024 15:34
@Eeebru Eeebru enabled auto-merge (squash) November 5, 2024 15:41
@Eeebru Eeebru merged commit 804192b into main Nov 5, 2024
9 of 10 checks passed
@Eeebru Eeebru deleted the BRE-139-rollout-workflow-linter-v-2 branch November 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants