Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-138] - Fix Workflow Name Underscore Error and Enforce Action Version Comment #30

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Nov 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BRE-139

📔 Objective

  • Fix Workflow Name Underscore Error and Enforce Action Version Comment
  • All other while lines changes are black formating changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner November 12, 2024 01:21
Copy link

github-actions bot commented Nov 12, 2024

Logo
Checkmarx One – Scan Summary & Details552e0fc5-2663-4f1b-8b72-986946540178

No New Or Fixed Issues Found

src/bitwarden_workflow_linter/rules/underscore_outputs.py Outdated Show resolved Hide resolved
tests/rules/test_name_capitalized.py Outdated Show resolved Hide resolved
Eeebru and others added 2 commits November 12, 2024 08:34
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
@Eeebru Eeebru requested a review from vgrassia November 12, 2024 15:34
@Eeebru Eeebru merged commit 69f2ef2 into main Nov 13, 2024
8 checks passed
@Eeebru Eeebru deleted the BRE-410-fix-workflow-linter-bug-2 branch November 13, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants