Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter of support - upload form #697

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Jul 17, 2024

📝 A short description of the changes

  • re-worked upload form for both JS and non-JS versions
  • updated copy
  • added checkboxes to support letters sections

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1199154381249427/1206750664011265/f

:shipit: Deployment implications

None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@Lubosky Lubosky force-pushed the letter-of-support-upload-form branch from a6901f4 to 55240da Compare July 17, 2024 14:05
@Lubosky Lubosky marked this pull request as ready for review July 17, 2024 14:10
@Lubosky Lubosky force-pushed the letter-of-support-upload-form branch from 55240da to a4ffb9c Compare July 17, 2024 15:38
return if wait > (now - last)

fn.apply null, arguments
last = now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@Lubosky Lubosky merged commit d8e36ee into main Jul 18, 2024
5 of 6 checks passed
@Lubosky Lubosky deleted the letter-of-support-upload-form branch July 18, 2024 11:38
@TheDancingClown TheDancingClown mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants