-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/verify receipt auto refresh #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed refreshReceipt method from SwiftyStoreKit.swift as this is now performed internally
bizz84
commented
May 18, 2017
/** | ||
* Verify application receipt | ||
* - Parameter password: Only used for receipts that contain auto-renewable subscriptions. Your app’s shared secret (a hexadecimal string). | ||
* - Parameter session: the session used to make remote call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of date documentation
bizz84
commented
May 18, 2017
SwiftyStoreKit/SwiftyStoreKit.swift
Outdated
@@ -30,13 +30,14 @@ public class SwiftyStoreKit { | |||
|
|||
private let paymentQueueController: PaymentQueueController | |||
|
|||
private var receiptRefreshRequest: InAppReceiptRefreshRequest? | |||
fileprivate let receiptVerificator: InAppReceiptVerificator | |||
|
|||
init(productsInfoController: ProductsInfoController = ProductsInfoController(), | |||
paymentQueueController: PaymentQueueController = PaymentQueueController(paymentQueue: SKPaymentQueue.default())) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass receiptVerificator
to init
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the receipt verification flows by removing the
refreshReceipt
method from the public API.Now clients only need to call
verifyReceipt
and the receipt is refreshed internally if needed.Related issue: #42