Swift 4.1 / Xcode 9.3 Support

[mattbarker016]

Removed warnings from flatMap depreciation. Changed to compactMap

[bizz84]

	1 Error
🚫	Tests were not updated

Generated by 🚫 Danger

[mattbarker016]

Changed branch, sorry about that! I'm guessing Travis isn't configured for Swift 4.1 for the other errors.

[bizz84]

Will this still compile with Xcode 8 though?

Some users have not upgraded yet and I'm wary of introducing changes that may break the build on non-latest tools.

[mattbarker016]

Would adding if #available(iOS 11.3, *) solve it? I can try when I’m near my computer.

[AndrewBennet]

Instead of if #available(iOS 11.3, *) I think you'll want something like:

#if swift(>=4.1)
let receiptItems = nonCancelledReceiptsInfo.compactMap { ReceiptItem(receiptInfo: $0) }
#else
let receiptItems = nonCancelledReceiptsInfo.flatMap { ReceiptItem(receiptInfo: $0) }
#endif

[AndrewBennet]

Cheers for updating! There's one typo in that commit though, using compactMap in both the #if and #else cases - I left a comment.

[mattbarker016]

Ugh, my bad

[AndrewBennet]

Hi @bizz84 - Can you explain what the Danger check is? Do tests need to be touched for every change?

[bizz84]

@mattbarker016 @AndrewBennet thanks for contributing! Don't worry about the Danger check. It's not very precise.