Add AppRouteObserver and route name to all pageBuilders #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how to add a
NavigatorObserver
to GoRouter-based apps.Unfortunately, adding
observers: [AppRouterObserver()]
is not enough and all route names will be null, unless an explicitname
is added inside thepageBuilder
:But there are still cases where it doesn't work reliably.
See this issue for more details:
flutter/flutter#112185