Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logs not being parsed in stackdriver. #22

Merged
merged 8 commits into from
Aug 30, 2021
Merged

fix: logs not being parsed in stackdriver. #22

merged 8 commits into from
Aug 30, 2021

Conversation

simenandre
Copy link
Member

@simenandre simenandre commented Aug 30, 2021

Adds @google-cloud/logging. Renames stackdriver to google.

Improves readability on tests.

BREAKING CHANGES: Exports are removed: StructuredJson, StructureJsonSeverity, INSERT_ID_KEY, LABELS_KEY, OPERATION_KEY, SOURCE_LOCATION_KEY, SPAN_ID_KEY, TRACE_KEY, TRACE_SAMPLED_KEY. You can find these same types in @google-cloud/logging. stackdriver type is renamed to google.

Adds `@google-cloud/logging`. Also renames `stackdriver` to `google`.
* main:
  build(deps-dev): Bump @types/jest from 26.0.24 to 27.0.1 (#14)
  build(deps-dev): Bump @slack/web-api from 6.3.0 to 6.4.0 (#17)
  build(deps-dev): Bump @typescript-eslint/eslint-plugin (#18)
  build(deps-dev): Bump eslint-plugin-import from 2.23.4 to 2.24.2 (#19)
  build(deps-dev): Bump husky from 7.0.1 to 7.0.2 (#20)
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #22 (eefd2cc) into main (be9e915) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines           50        65   +15     
  Branches         3         4    +1     
=========================================
+ Hits            50        65   +15     
Impacted Files Coverage Δ
src/__tests__/fixtures.ts 100.00% <100.00%> (ø)
src/constants.ts 100.00% <100.00%> (ø)
src/slack.module.ts 100.00% <100.00%> (ø)
src/slack.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9e915...eefd2cc. Read the comment docs.

@simenandre simenandre merged commit 5f4d393 into main Aug 30, 2021
@simenandre simenandre deleted the fix-google branch August 30, 2021 07:44
This was referenced Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant