Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export WebStorageStateStore from oidc-client-ts #1056

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jankc
Copy link
Contributor

@jankc jankc commented Mar 7, 2024

WebStorageStateStore is exported from oidc-client-ts but not re-exported from oidc-react. It is useful e.g. for switching userManager's userStore from session storage to local storage:

const userManager = new UserManager({
  userStore: new WebStorageStateStore({ store: window.localStorage }),
  ...
});

As userStore property is quite strictly typed creating own instance of WebStorageStateStore is not straightforward. It is also prone to incompatibility with future version of oidc-client-ts.

See Add export for WebStorageStateStore from oidc-client #344

@jankc jankc force-pushed the fix/export-webstoragestatestore branch from 8b879f1 to 63e3a38 Compare March 7, 2024 10:53
@jankc jankc marked this pull request as ready for review March 7, 2024 10:53
@jankc jankc changed the title Add export for WebStorageStateStore from oidc-client-ts feat: Add export for WebStorageStateStore from oidc-client-ts Mar 11, 2024
@jankc jankc force-pushed the fix/export-webstoragestatestore branch from 63e3a38 to 59e0e35 Compare March 11, 2024 10:02
@jankc jankc changed the title feat: Add export for WebStorageStateStore from oidc-client-ts feat: export WebStorageStateStore from oidc-client-ts Mar 11, 2024
@jankc jankc force-pushed the fix/export-webstoragestatestore branch from 59e0e35 to 1f6ca86 Compare March 11, 2024 10:07
@jankc jankc force-pushed the fix/export-webstoragestatestore branch from 1f6ca86 to 8799eaa Compare March 11, 2024 10:12
@simenandre simenandre merged commit 2d6f750 into bjerkio:main Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants