fix: add args to props of provider

[hosseinmd]

Thank you and other contributors about this good module.

By this PR we are able to add args to signinRedirect when autoSignin is true

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run yarn generate-docs to generate some!

[hosseinmd]

We need this to handle callback URL, mean user want to go a route after we redirected from identitie server, I want to redirect user to her wanted root.

Could you merge this?

[simenandre]

Thanks for opening this pull request!

Not sure you need this to do what you want.
You could use the hooks (e.g. onSignIn to redirect the user).

I would love to see a simple test for this before landing 👍
Thank you!

[simenandre]

We should probably be more descriptive with the naming of this argument. args seem to generic, would you agree?

[hosseinmd]

callbackState may be more appropriate

[alimahmoodi]

you could get it with a callback instead of state like getSigninState

[abebehailu]

Would it not be better to add return value for onBeforeSignIn so you can create the args object for each signin? This way, you could e.g. create different state during login.

[hosseinmd]

The goal is to give the parameter to signinRedirect

[abebehailu]

Exactly, I have the same issue. But if row 120, the call to onBeforeSignIn (which is a method that can be implemented) could return a args object, it can be passed in the next row to signinRedirect.

Something like:

let args = {};
if(onBeforeSignIn) {
args = onBeforeSignIn();
}
userManager.signinRedirect(args);

[abebehailu]

The onBeforeSignIn method is only called here as far as I can see so it seems like it is only used fo the autoSignIn flow. Hence, I think it might make sense to implement it with a possible return value since it will always be called before the signinRedirect and only if the autoSignIn is true.

[abebehailu]

@hosseinmd Any progress with this PR?

[hosseinmd]

The onBeforeSignIn method is only called here as far as I can see so it seems like it is only used fo the autoSignIn flow. Hence, I think it might make sense to implement it with a possible return value since it will always be called before the signinRedirect and only if the autoSignIn is true.

Do you think other users will understand this easily?