Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata parameter to AuthContext #997

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

hwo-wd
Copy link
Contributor

@hwo-wd hwo-wd commented Apr 19, 2023

Useful for providers missing proper CORS headers.

Continuation of #715 (comment)

Note:
I've tried running generate-docs but was unsuccessful:

yarn run v1.22.19
$ typedoc --gitRevision main --out docs src
[info] Loaded plugin typedoc-plugin-markdown
TypeDoc exiting with unexpected error:
TypeError: page.template is not a function
    at MarkdownTheme.render (D:\dev\work\temp\oidc-react\node_modules\typedoc-plugin-markdown\dist\theme.js:39:49)
    at Renderer.renderDocument (D:\dev\work\temp\oidc-react\node_modules\typedoc\dist\lib\output\renderer.js:183:40)
    at D:\dev\work\temp\oidc-react\node_modules\typedoc\dist\lib\output\renderer.js:159:22
    at Array.forEach (<anonymous>)
    at Renderer.render (D:\dev\work\temp\oidc-react\node_modules\typedoc\dist\lib\output\renderer.js:157:25)
    at async Application.generateDocs (D:\dev\work\temp\oidc-react\node_modules\typedoc\dist\lib\application.js:300:9)
    at async run (D:\dev\work\temp\oidc-react\node_modules\typedoc\dist\lib\cli.js:110:13)
error Command failed with exit code 6.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Copy link
Member

@simenandre simenandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! There seems to be a little formatting issue, but other than that I think this looks fine.

Useful  for providers missing proper CORS headers.
@hwo-wd
Copy link
Contributor Author

hwo-wd commented Apr 20, 2023

Thanks, I've added the missing comma, should pass now 👍

@simenandre
Copy link
Member

Btw, if you wanna contribute more, feel free to join our Discord server: discord.gg/SXMpgmPq5F

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@8462027). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #997   +/-   ##
=======================================
  Coverage        ?   98.91%           
=======================================
  Files           ?        1           
  Lines           ?       92           
  Branches        ?       35           
=======================================
  Hits            ?       91           
  Misses          ?        1           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simenandre simenandre merged commit 1e6703b into bjerkio:main Apr 21, 2023
@simenandre
Copy link
Member

Released in https://github.com/bjerkio/oidc-react/releases/tag/v3.1.0

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants