Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add employee model to timesheet model #61

Closed
wants to merge 1 commit into from

Conversation

braaar
Copy link
Member

@braaar braaar commented Jan 12, 2023

I need to access the email field on timesheet.employee and noticed that the employee field only contained id.

@braaar braaar requested a review from simenandre January 12, 2023 14:02
employee: rt.Record({
id: rt.Number,
}),
employee: employeeRt,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until further notice, we'd need to use resourceRef for this. Related to #63

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I should just close this PR, then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so.

@simenandre simenandre closed this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants