Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make macro compile error messages more informative #42

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Make macro compile error messages more informative #42

merged 2 commits into from
Aug 13, 2024

Conversation

bytedream
Copy link
Contributor

The compile errors emitted by the gatt! macro when the input isn't in the expected format aren't very informative. I've changed all compile_error!("Unexpected") to more accurate message in this PR.

bleps-macros/src/lib.rs Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Owner

bjoernQ commented Aug 12, 2024

Thanks! This really improves things on the user's side. If you don't mind to fix having the name of an unexpected field printed that would be awesome (for Service,Characteristic and Descriptor)

@bytedream
Copy link
Contributor Author

Ty :) I fixed the unexpected field messages

Copy link
Owner

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ bjoernQ merged commit 793f248 into bjoernQ:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants