Rework the public api and implement a bunch of missing methods #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids issues when the wasm module uses names conflicting with builtin javascript properties.
|
#72 was extracted out of this branch. Several other improvements that didn't require a breaking change to the public api haven't been extracted out because they conflicted a lot with other changes that did need breaking changes. |
This way individual Fd implementations don't have to handle vectorized reads/writes and don't need direct access to the wasm linear memory.
Either their signature will likely change once they are actually implemented in one of the Fd impls or they are not strictly necessary to exist.
|
Published as v0.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests couldn't be fixed without breaking the public api. While I'm breaking the public api anyway I figured I would make a bunch more improvements to it.
This PR will be merged somewhere in the coming days and published as v0.3.0.