Allow for custom table and adapter names #105
Conversation
| public function getTableName() | ||
| { | ||
| if (!$this->tableName) { | ||
| $this->setTableName(static::DEFAULT_TABLE_NAME); |
There was a problem hiding this comment.
Set this on the property instead and remove the getter
There was a problem hiding this comment.
Why do you want to remove the getter? The way I did it was in line with other modules like ZFC.
There was a problem hiding this comment.
The getter here adds unnecessary logic that simply handles the default value of the property. This class should actually be more like an immutable service, so setters/getters should probably completely be removed
|
Can you please also add tests for the factory at least? Testing the provider itself is probably too messy |
|
Oops, kinda missed the fact that you had tests. Will provide these asap. |
|
Please also rebase (I fixed the travis runner in the mean time) |
|
Cannot merge without rebase anymore (FYI) |
|
Closing - please eventually open a new PR |
|
If this feature is still not merged we can't change the table name via the config file ? Should we open a new PR ? |
|
@Angusfr yes please |
|
k i'm gonna check how to do this. My first time :') |
|
@Angusfr give it a try! And don't worry about messing it up :) |
|
Should i use the code previously submitted here ? |
|
@Angusfr give it a try from scratch |
No description provided.