This repository has been archived by the owner on May 14, 2018. It is now read-only.
Hotfix/issue #104 #113
Merged
Hotfix/issue #104 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'default' is a reserved keyword in mysql, so I changed it to is_default. I have not seen an occurrence of this column in the actual code, so impact seems minimal. - Although a parent column is present, it did not have a foreign key yet, so added that. - The character set was set to utf8, given that role names are something used internally, and the fact that they're used as primary keys, I figured they could better be latin1 (reasoning below) - Because Mysql reserves the maximum amount of bytes for a varchar field, it would reserve 3*255 bytes (3 because of charset, 255 because of maxlenght). This seems a tad overkill, hence I reduced it to a more sensible amount (I think).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #104