Clean up the option parser #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the regular expression logic and splitting out of the parser_args vs exec_args in favor of using OptionParser.order! which will not complain about unknown flags because order will stop at the first unknown argument. This is a dramatic improvement to the CLI code clarity. Co-authored-by: Ben Sherman <bensherman@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the regular expression logic and splitting out of the parser_args vs exec_args in favor of using OptionParser.order! which will not complain about unknown flags because order will stop at the first unknown argument.
This is a dramatic improvement to the CLI code clarity.
Closes #381
Thanks to @bensherman for pairing up to better understand what was going on under the hood, and finding the .order! method.
/cc @walro