feat(config)!: resolve config.variant in favour of uniq config.theme (DEV-132)
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nikbrunner and the rest of your teammates on |
nikbrunner
force-pushed
the
feature/dev-132-merge-configvariant-configtheme-into-one
branch
from
428c357 to
9b6575e
Compare
nikbrunner
changed the title
variant. use only unique theme key.variant. use only unique theme key. (DEV-132)
nikbrunner
force-pushed
the
feature/dev-132-merge-configvariant-configtheme-into-one
branch
from
9b6575e to
e60ff37
Compare
nikbrunner
changed the title
variant. use only unique theme key. (DEV-132)config.variant in favour of uniq config.theme (DEV-132)
nikbrunner
force-pushed
the
feature/dev-132-merge-configvariant-configtheme-into-one
branch
6 times, most recently
from
70d53e4 to
85421d6
Compare
Also check only the first line of the commit message against the regex validation pattern.
Resolve `config.variant` in favour of using one simple unique `config.theme` string. This makes things much easier. BREAKING CHANGE: `config.variant` no longer exists. Please update your `config.theme` string. (e.g. `winter` => `terra_winter_night`). If you were using `util.select_variant()` before, please remove it and use `util.select_theme()` instead.
nikbrunner
force-pushed
the
feature/dev-132-merge-configvariant-configtheme-into-one
branch
3 times, most recently
from
777556d to
3dfb17e
Compare
nikbrunner
force-pushed
the
feature/dev-132-merge-configvariant-configtheme-into-one
branch
from
3dfb17e to
7b252e0
Compare
Merge activity
|
nikbrunner
deleted the
feature/dev-132-merge-configvariant-configtheme-into-one
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies many things and makes it more flexible.