Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu entry in german translation cut off #28

Closed
2 tasks done
terr72 opened this issue Jun 2, 2021 · 9 comments · Fixed by #40
Closed
2 tasks done

Menu entry in german translation cut off #28

terr72 opened this issue Jun 2, 2021 · 9 comments · Fixed by #40
Labels
Class::Cliped Tab text truncation Compenent::Panel Panel menu (not pop-up) Env::Linux Issues on Linux Issue::Bug Something isn't working Priority::Low The importance is low

Comments

@terr72
Copy link

terr72 commented Jun 2, 2021

Describe the bug
The menu entry "Neues privates Fenster" is shrinked to "Neues privates Fens...".
See the attached screenshot

Expected behavior
"Neues privates Fens..." should appear as "Neues privates Fenster"

Environment (please complete the following information):

  • Firefox Version: 89.0
  • OS:
    • Linux
  • Theme:
    • System Default
      • GTK Theme Name(Only Linux User): [sample] Adwaita, Adwaita-Dark, Breath, Breath-Dark

menu

@terr72 terr72 added the Issue::Bug Something isn't working label Jun 2, 2021
@black7375 black7375 added Class::Cliped Tab text truncation Compenent::Panel Panel menu (not pop-up) Env::Linux Issues on Linux Priority::Low The importance is low labels Jun 2, 2021
@SimYunSup
Copy link
Contributor

SimYunSup commented Jun 2, 2021

grafik
This bug works on Windows/SystemDefault, too.

@black7375
Copy link
Owner

black7375 commented Jun 2, 2021

It seems to be a problem with the length.
Text truncation is also an issue that needs to be solved, but it's not as serious a bug as a misaligned layout.

We need to check of Photon behavior later.
They are similar in size, so maybe there is a solution.

@SimYunSup
Copy link
Contributor

SimYunSup commented Jun 2, 2021

This panel on Lepton should set wide width because toolItem is too fit to add icon. So, It needs to modify width of the panel.

  #appMenu-popup panelview {
    width: 30em !important; /* can modify panel width, original: 22.5em */
  }

@black7375
Copy link
Owner

black7375 commented Jun 2, 2021

It looks a bit wide in English.

Before - After
image
image


This does not mean that there is no other way.
We can also set it up differently by language.
image

/* Sample Code */
:root[lang="de-DE"] #appMenu-popup panelview {
  width: 30em !important; /* can modify panel width, original: 22.5em */
}

@terr72
Copy link
Author

terr72 commented Jun 2, 2021

The german language string set by Firefox is de only (checked for both Linux and Windows).
Also 23em is sufficient (at least for Linux, not tested with Windows).
This will not only be a cure for german, I suspect a few other languages with longer words are affected by this.

/* Sample Code */
:root[lang="de"] #appMenu-popup panelview {
  width: 23em !important; /* can modify panel width, original: 22.5em */
}

@SimYunSup
Copy link
Contributor

Proton have translation cut off problem in another language too. So, I suggest width: 25em because I think it's reasonable in many language including English.
image

/* Panel View */
:root #appMenu-popup panelview {
  width: 25em !important; /* can modify panel width, original: 22.5em */
}

Can I make pull request of this?

@black7375
Copy link
Owner

black7375 commented Jun 3, 2021

@SimYunSup LGTM
If you open the PR, I'll merge it.

black7375 added a commit that referenced this issue Jun 3, 2021
Fix: Panel - Fix text cut off in some language #28
@black7375 black7375 reopened this Jun 3, 2021
@black7375
Copy link
Owner

Once we adjusted the default panel size.

black7375 added a commit that referenced this issue Jun 5, 2021
@black7375
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Cliped Tab text truncation Compenent::Panel Panel menu (not pop-up) Env::Linux Issues on Linux Issue::Bug Something isn't working Priority::Low The importance is low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants