Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White outline on the sides of tabs and across the top of the address bar. #99

Closed
TheReverend403 opened this issue Jun 17, 2021 · 5 comments
Labels
Class::Color Color, background, blur, etc. Component::Toolbar Toolbar or navbar Distribution::Photon-Style Photon style distribution related Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working

Comments

@TheReverend403
Copy link

Screenshot

Environment:
Firefox Version: 89.0
OS: Windows
Theme: Dark

@TheReverend403 TheReverend403 added the Issue::Bug Something isn't working label Jun 17, 2021
@black7375 black7375 added Class::Color Color, background, blur, etc. Component::Toolbar Toolbar or navbar labels Jun 18, 2021
@black7375
Copy link
Owner

black7375 commented Jun 28, 2021

It has been confirmed to appear in some themes.

/* photon */
#navigator-toolbox:-moz-lwtheme {
    --tabs-border-color: rgba(0,0,0,.3);
}

/* proton */
:root {
  --tabs-border-color: threedshadow;
}

The line that appear around the tabs are intentional.

@TheReverend403
Copy link
Author

They don't look intentional when compared to the exact same CSS on Linux. They're far more subtle compared to Windows where it's just a solid white line.

screen

@TheReverend403
Copy link
Author

TheReverend403 commented Jun 29, 2021

For the record, I've made some slight customisations to the photon-style branch, nothing that should affect borders between tabs though.

_userChrome.css is userChrome.css from this repo.

@import url("_userChrome.css") screen;

:root {
    --autocomplete-popup-highlight-background: #8c54fe !important;
    --focus-outline-color: #8c54fe !important;
    --lwt-popup-brighttext-url-color: #b5b5b5 !important;
    --url-match-color: #fd971f;
}

#urlbar:is([focused]) > #urlbar-background, #urlbar-container .urlbar-input-box {
    border-color: var(--focus-outline-color) !important;
}

.urlbarView-row:not([selected]) .urlbarView-title strong,
.urlbarView-row:not([selected]) .urlbarView-url strong {
    color: var(--url-match-color) !important;
}

@black7375 black7375 added the Env::Windows Issues on Windows10, Windows11, unknown windows label Jun 29, 2021
@black7375
Copy link
Owner

black7375 commented Jun 29, 2021

Oh, I checked. I will check it.
I think I forgot to delete it by mistake.


I adjusted a few more things.
Now it looks much better than before.
image

This commit will be merged while working on an upcoming release.
32bafa7

@black7375 black7375 added the Distribution::Photon-Style Photon style distribution related label Jun 29, 2021
@black7375
Copy link
Owner

The surest way is to remove box-shadow.

  #nav-bar {
    box-shadow: none !important;
  }

But some themes need box-shadow, so it will provided by wiki.
https://github.com/black7375/Firefox-UI-Fix/wiki/Compatibility-Issues-Solution#white-outline-on-the-top-of-address-bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Color Color, background, blur, etc. Component::Toolbar Toolbar or navbar Distribution::Photon-Style Photon style distribution related Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants