fix(components/forms): update checkbox and checkbox group harness to return false instead of throw when no form errors are present #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…return false instead of throw when no form errors are present
Blackbaud-CoreyArcher
added
the
risk level (author): 2
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c37231c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 8 targets
Sent with 💌 from NxCloud. |
|
Component Storybooks: Apps: |
Blackbaud-SteveBrush
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#3032270
BREAKING CHANGE
Previously the
hasRequiredError()and other error reporting methods on checkbox and checkbox group harnesses would return false if the specified error was not present alongside other errors, but throw an exception if no errors were present at all. Now these methods simply return false if the specified error is not present regardless of the overall error state.