feat(components/datetime)!: remove deprecated required inputs and update error validation #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 22, 2024 19:06
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit fc6eae6. Check the Nx Cloud Source Control Integration documentation for more information. Alternatively, you can contact us at cloud-support@nrwl.io. Sent with 💌 from NxCloud. |
Blackbaud-SandhyaRajasabeson
added
the
risk level (author): 3
libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.html
Show resolved
Hide resolved
libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.ts
Show resolved
Hide resolved
libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.ts
Outdated
Show resolved
Hide resolved
libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.ts
Outdated
Show resolved
Hide resolved
libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.ts
Outdated
Show resolved
Hide resolved
libs/components/datetime/src/lib/modules/date-range-picker/date-range-picker.component.ts
Outdated
Show resolved
Hide resolved
Blackbaud-SteveBrush
approved these changes
Aug 28, 2024
Blackbaud-SandhyaRajasabeson
deleted the
date-range-picker-update-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#2976025
BREAKING CHANGE: Show first class errors under the input that it corresponds to. Handle touched and dirty at the individual input level and not at the form group level.