Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #123 - Avoid caching song_id form parameter #147

Merged

Conversation

jaredmoody
Copy link
Contributor

Restructure the add to playlist form so that instead of a list of buttons, each generating a form, we wrap the playlist buttons in a single form and each playlist button changes the form action when clicked to the proper playlist url.

This allows caching each button and fixes the bug where the song_id was cached with the html for each button.

Restructure the add to playlist form so that instead of a list of buttons, each generating a form, we wrap the playlist buttons in a single form and each playlist button changes the form action when clicked to the proper playlist url.

This allows caching each button and fixes the bug where the song_id was cached with the html for each button.
@coveralls
Copy link

coveralls commented Mar 5, 2022

Pull Request Test Coverage Report for Build 1939012958

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.923%

Totals Coverage Status
Change from base Build 1933364594: 0.0%
Covered Lines: 693
Relevant Lines: 715

💛 - Coveralls

@jaredmoody
Copy link
Contributor Author

In addition to the CI passing, I deployed this patch to my production environment and confirmed it resolves the issue.

@aidewoode aidewoode merged commit b5719e6 into blackcandy-org:master Mar 7, 2022
@aidewoode
Copy link
Member

Thanks, great implementation, I didn't know button has a formaction attribute before.

@jaredmoody
Copy link
Contributor Author

Thanks! I learned about formaction recently too!

@jaredmoody jaredmoody deleted the add-to-playlist-cache-issue-#123 branch March 7, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants