Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Album and Artist image logic into concern #172

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Consolidate Album and Artist image logic into concern #172

merged 1 commit into from
Jun 6, 2022

Conversation

jaredmoody
Copy link
Contributor

The code around attaching images to Albums and Artists was nearly identical, so I extracted it, what do you think?

@coveralls
Copy link

coveralls commented Jun 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2445538445

  • 22 of 22 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 96.823%
Totals Coverage Status
Change from base Build 2445362100: -0.02%
Covered Lines: 762
Relevant Lines: 787
💛 - Coveralls

aidewoode
aidewoode requested changes Jun 6, 2022
View reviewed changes
app/models/concerns/imageable.rb Outdated Show resolved Hide resolved
@aidewoode aidewoode merged commit 5da2533 into blackcandy-org:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidewoode aidewoode aidewoode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredmoody @coveralls @aidewoode