Fix IDETECT-4207: ArgumentOutOfIndexException in Windows (#21)

* Fix IDETECT-4207: make null check before using the variable * Addressed PR comment
blackducksoftware · Feb 22, 2024 · 4507761 · 4507761
1 parent 38c77b2
commit 4507761
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/detect-nuget-inspector/detect-nuget-inspector/Inspection/Inspectors/SolutionInspector.cs b/detect-nuget-inspector/detect-nuget-inspector/Inspection/Inspectors/SolutionInspector.cs
@@ -129,14 +129,14 @@ public Container GetContainer()
                                 bool fileNotFound = true;
                                 while (fileNotFound)
                                 {
-                                    parentPath =
-                                        parentPath.Substring(0, OperatingSystem.IsWindows() ? parentPath.LastIndexOf("\\") : parentPath.LastIndexOf("/"));
                                     string checkFile = Path.Combine(parentPath, projectRelativePath);
-                                    if (parentPath.Equals(Path.GetPathRoot(solutionDirectory)) || parentPath.Equals(""))
+                                    if (parentPath.Equals("") || parentPath.Equals(Path.GetPathRoot(solutionDirectory)))
                                     {
                                         Console.WriteLine("The Path provided in the sln file is wrong, will skip parsing over this file");
                                         break;
                                     }
+                                    parentPath =
+                                        parentPath.Substring(0, OperatingSystem.IsWindows() ? parentPath.LastIndexOf("\\") : parentPath.LastIndexOf("/"));
                                     directoryPackagesExists = File.Exists(checkFile);
                                     fileNotFound = !directoryPackagesExists;
                                     projectPath = checkFile;