Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradient based sampler for latent Gaussian models #247

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Add Gradient based sampler for latent Gaussian models #247

merged 1 commit into from
Jul 9, 2022

Conversation

AdrienCorenflos
Copy link
Contributor

This is a clean up of the commit history of #228, implementing the marginal sampler of https://rss.onlinelibrary.wiley.com/doi/full/10.1111/rssb.12269.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #247 (8cd5cc0) into main (e9f8bbe) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 8cd5cc0 differs from pull request most recent head 877bbe8. Consider uploading reports for the commit 877bbe8 to get more accurate results

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   98.33%   98.40%   +0.07%     
==========================================
  Files          41       42       +1     
  Lines        1621     1693      +72     
==========================================
+ Hits         1594     1666      +72     
  Misses         27       27              
Impacted Files Coverage Δ
blackjax/__init__.py 100.00% <ø> (ø)
blackjax/kernels.py 99.43% <100.00%> (+0.02%) ⬆️
blackjax/mcmc/__init__.py 100.00% <100.00%> (ø)
blackjax/mcmc/marginal_latent_gaussian.py 100.00% <100.00%> (ø)
blackjax/optimizers/lbfgs.py 100.00% <0.00%> (ø)
blackjax/vi/pathfinder.py 94.44% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f8bbe...877bbe8. Read the comment docs.

@@ -5,6 +5,7 @@
elliptical_slice,
hmc,
mala,
marginal_latent_gaussian,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just go with mGrad like in the paper?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not very standard...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, if you want to change the name, please do. I'm not attached to it.

@rlouf rlouf requested a review from junpenglao July 6, 2022 15:37
@rlouf
Copy link
Member

rlouf commented Jul 6, 2022

Renamed to mgrad_gaussian. Good to merge, we'll have to revisit the PyTree situation later.

@rlouf rlouf self-assigned this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants