Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced = with is Operator while comparing with None #2003

Closed
wants to merge 2 commits into from
Closed

Replaced = with is Operator while comparing with None #2003

wants to merge 2 commits into from

Conversation

noob6t5
Copy link

@noob6t5 noob6t5 commented Nov 21, 2024 •
edited
Loading

In this PR i have removed = with is operator while Comparing with None

Follwing pep-8

@liquidsec liquidsec changed the base branch from stable to dev November 21, 2024 20:08
@cclauss
Copy link
Contributor

cclauss commented Nov 22, 2024

Duplicate of

@TheTechromancer
Copy link
Collaborator

Thanks @noob6t5 and @cclauss for your work on this. I'll give the PR to whoever updates our deps+actions to use ruff instead of black and flake.

@cclauss cclauss mentioned this pull request Nov 23, 2024
Merged
@cclauss
Copy link
Contributor

cclauss commented Nov 23, 2024

This pull request is correct and can be merged.

@cclauss
Copy link
Contributor

cclauss commented Nov 23, 2024

Git conflicts

@noob6t5
Copy link
Author

noob6t5 commented Nov 24, 2024

Hello there,

What's causing the conflict?

@cclauss
Copy link
Contributor

cclauss commented Nov 24, 2024

@cclauss
Copy link
Contributor

cclauss commented Nov 25, 2024

This can be closed. These changes were made in

@noob6t5 noob6t5 closed this Nov 25, 2024
@noob6t5 noob6t5 deleted the fix/used-is-operator branch November 25, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@TheTechromancer TheTechromancer TheTechromancer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noob6t5 @cclauss @TheTechromancer