Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Refactor done while rebasing #1399 which added a new probe type with no specified PID
While looking at this I got sidetracked into looking into the J-Link PIDs, discovering they have a whole meaning behind them, it seems they use them to list the USB Class interfaces the probe will have. I added this information to the protocol header, along with the masks and offsets required to interpret them, but did not implement anything with them, I don't think there's much value in parsing it for now, but might be useful later and serves at least as documentation
Test after the change:
Your checklist for this pull request
It builds for hardware native (make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues