Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: warning shadow #1594

Merged
merged 9 commits into from
Aug 17, 2023
Merged

Fix: warning shadow #1594

merged 9 commits into from
Aug 17, 2023

Conversation

perigoso
Copy link
Contributor

Detailed description

Fix warnings for -Wshadow=local

See #1590 for context

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@perigoso perigoso mentioned this pull request Aug 10, 2023
Open
43 tasks
@dragonmux dragonmux added the Enhancement General project improvement label Aug 13, 2023
dragonmux
dragonmux requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR's looking good - there are some small changes to be made but then we're happy to merge this.

Good call with the bmp_info struct and info -> bmda_probe_info! We're particularly happy to see the probe type macros sorted out.

src/command.c Outdated Show resolved Hide resolved
src/include/command.h Outdated Show resolved Hide resolved
src/platforms/hosted/cmsis_dap.c Outdated Show resolved Hide resolved
src/platforms/hosted/platform.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added this to the v1.10 milestone Aug 13, 2023
@perigoso perigoso force-pushed the fix/warning-shadow branch from b94538d to 3b16ef0 Compare August 17, 2023 11:44
dragonmux
dragonmux approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@dragonmux dragonmux merged commit 9047332 into blackmagic-debug:main Aug 17, 2023
@perigoso perigoso deleted the fix/warning-shadow branch August 17, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Enhancement General project improvement
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@perigoso @dragonmux