Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: warning pedantic empty init #1596

Merged
merged 19 commits into from
Aug 11, 2023
Merged

Fix: warning pedantic empty init #1596

merged 19 commits into from
Aug 11, 2023

Conversation

perigoso
Copy link
Contributor

Detailed description

Fix (some) warnings for -Wpedantic

See #1590 for context

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@perigoso perigoso mentioned this pull request Aug 10, 2023
Open
43 tasks
@perigoso perigoso changed the title Fix/warning pedantic empty init Fix: warning pedantic empty init Aug 10, 2023
dragonmux
dragonmux requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - there's only one thing we spotted in review and then we can merge this as it's a fairly mechanical change that doesn't impact how this code all works.

src/target/nrf51.c Outdated Show resolved Hide resolved
@dragonmux dragonmux added this to the v1.10 milestone Aug 10, 2023
@dragonmux dragonmux added the Enhancement General project improvement label Aug 10, 2023
perigoso added 19 commits August 11, 2023 19:56
@perigoso @rg-silva
remote: fix empty init pedantic warning
3d3b5ac 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
cli: fix empty init pedantic warning
81ec5f1 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
hosted/cmsis_dap: fix empty init pedantic warning
04f9a94 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
hosted/dap_commands: fix empty init pedantic warning
156a25e 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
hosted/dap: fix empty init pedantic warning
68a8443 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
hosted/ftdi: fix empty init pedantic warning
c86e959 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
hosted/gdb_if: fix empty init pedantic warning
d085213 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
hosted/serial_win: fix empty init pedantic warning
864b305 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
adiv5: fix empty init pedantic warning
c2c4437 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/imxrt: fix empty init pedantic warning
21f32b1 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
jtag_scan: fix empty init pedantic warning
7393d89 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/lpc: fix empty init pedantic warning
3ca08f7 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/nrf51: fix empty init pedantic warning
abe3486 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/sam3x: fix empty init pedantic warning
3b4ad32 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/samd: fix empty init pedantic warning
a8b5327 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/samx5x: fix empty init pedantic warning
6717559 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/stm32f4: fix empty init pedantic warning
22de857 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/stm32g0: fix empty init pedantic warning
fe34449 
ISO C forbids empty initializer braces before C2X
@perigoso @rg-silva
target/stm32l4: fix empty init pedantic warning
f4b2d44 
ISO C forbids empty initializer braces before C2X
@perigoso perigoso force-pushed the fix/warning-pedantic-empty-init branch from 88dfd52 to f4b2d44 Compare August 11, 2023 18:57
dragonmux
dragonmux approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging!

@dragonmux dragonmux merged commit f042795 into blackmagic-debug:main Aug 11, 2023
@perigoso perigoso deleted the fix/warning-pedantic-empty-init branch August 11, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Enhancement General project improvement
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@perigoso @dragonmux