Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Target power soft-start for older native hardware #1621

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

dragonmux
Copy link
Member

Detailed description

Due to a small accident with Git, the initial commit for this patch is already on main as b83657e, so in this PR we fix a small mistake with the platform initialisation that saw the timer used by soft-start failing to be powered up on hardware older than the BMP v2.3 hardware.

This enables tpwr soft-start for hw1 and up.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added Enhancement General project improvement BMP Firmware Black Magic Probe Firmware (not PC hosted software) NativeHardware Official Black Magic Debug Hardware labels Sep 11, 2023
@dragonmux dragonmux added this to the v1.10 milestone Sep 11, 2023
@dragonmux dragonmux requested a review from esden September 11, 2023 01:59
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this patch on HW1,2 and 4. I am very satisfied with the results. For reference here some screenshots of the different hardware versios. Yellow trace is the PWR_BR (power enable pin, it is reverse logic, high is off low is on) the blue trace is the 3.3V rail.

HW1 without pwm
71527000-83B1-45A3-81DB-1E42339070C9_1_105_c

HW1 with pwm
D162CF78-327B-417B-A240-8D79E219910C_1_105_c

HW2 without pwm
23BA8C11-55F5-4F4D-88E3-681D16D89E78_1_105_c

HW2 with pwm
347DBE1A-4EE5-4C6C-9015-84A2E314354C_1_105_c

HW4 without pwm
B0D2F988-8872-46FD-9FBF-E3FBB82DE6BF_1_105_c

HW4 with pwm
0B56F413-C64E-488F-9EFB-2D3569236A48_1_105_c

As this is a significant improvement, let's merge this, and backport to v1.8 and v1.9 firmwares and create some new point releases. ;)

@dragonmux dragonmux marked this pull request as ready for review September 11, 2023 02:42
@esden esden merged commit 578eaaa into main Sep 11, 2023
6 checks passed
@dragonmux dragonmux deleted the feature/soft-start-for-older-native branch September 11, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMP Firmware Black Magic Probe Firmware (not PC hosted software) Enhancement General project improvement NativeHardware Official Black Magic Debug Hardware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants