Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: memleak/handling FTDI adapters #1624

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

lethalbit
Copy link
Contributor

This PR fixes a memory leak in bmp_libusb and a bug in ftdi_bmp.

The former was a missing probe_info_list_free inside a failure case for FTDI lookups. The latter being a case where the ftdi_lookup_cable_by_product would erroneously return false if the cable was specified on the command line with -c resulting in an incorrect lookup failure.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

…ing in a lookup failure if the cable type was specified on the command line
@dragonmux dragonmux added this to the v1.10 milestone Sep 16, 2023
@dragonmux dragonmux added Bug Confirmed bug BMD App Black Magic Debug App (aka. PC hosted) (not firmware) labels Sep 16, 2023
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll merge as soon as the builds finish. Thank you for the contribution!

@dragonmux dragonmux merged commit c7ebdb7 into blackmagic-debug:main Sep 16, 2023
6 checks passed
@lethalbit lethalbit deleted the aki/memleak branch September 23, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants