Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stlink: add config for the ISOL variant #1990

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

HrMitrev
Copy link
Contributor

@HrMitrev HrMitrev commented Nov 3, 2024

Detailed description

Just an addition to #1720 since the Makefile buld system was removed, this adds support for the host while building with meson

Your checklist for this pull request

Closing issues

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only see the one thing that needs a small tweak for consistency, and then this can be approved and merged.

'stlink_v2_isol',
type: 'boolean',
value: false,
description: 'Build for the ISOL variant of STlink v2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with naming, please use ST-Link v2 to refer to the family of boards.

@dragonmux dragonmux added this to the v2.0 release milestone Nov 5, 2024
@dragonmux dragonmux added Enhancement General project improvement Foreign Host Board Non Native hardware to runing Black Magic firmware on labels Nov 5, 2024
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution

@dragonmux dragonmux merged commit 9ac66f5 into blackmagic-debug:main Nov 18, 2024
36 checks passed
@HrMitrev HrMitrev deleted the isol branch November 18, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement General project improvement Foreign Host Board Non Native hardware to runing Black Magic firmware on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants