Code

Fix: CMSIS-DAP block I/O#1999

Code

Merged

esden merged 16 commits intomainblackmagic-debug/blackmagic:mainfrom fix/cmsis-dap-block-ioblackmagic-debug/blackmagic:fix/cmsis-dap-block-ioCopy head branch name to clipboardNov 17, 2024

+126-75

Commits

Commits on Nov 17, 2024

• hosted/cmsis_dap: Fixed the nomenclature of the CMSIS-DAP packet size variable

  dragonmux

  committed
  a1fc87f

• hosted/cmsis_dap: Implemented a variant on dap_run_cmd() which is specialised in mass data transfers so we get the the actual amount transferred

  dragonmux

  committed
  6c05e1e

• hosted/cmsis_dap: Fixed the lack of ZLP handling when a transfer moves a full packet amount of data, messing up the Bulk transfer transport state

  dragonmux

  committed
  0bf6b95

• hosted/dap_command: Fixed perform_dap_transfer_block_read() not properly detecting and handling short responses due to target errors, leading to very bad things happening on return

  dragonmux

  committed
  06eda37

• hosted/cmsis_dap: Fixed a small error in dap_adiv5_mem_read() which resulted in it not properly taking into account the command byte prefix in responses

  dragonmux

  committed
  1b8f102

• hosted/cmsis_dap: Fixed a small error in dap_adiv6_mem_read() which resulted in it not properly taking into account the command byte prefix in responses

  dragonmux

  committed
  658f2d2

• hosted/dap_command: Fixed a clang-tidy lint about a widening cast in perform_dap_transfer_block_write()

  dragonmux

  committed
  fa97ac7

• hosted/dap: Fixed the behaviour of the memory access setup routines to not crash when a fault occurs, but instead propagate it correctly

  dragonmux

  committed
  03fb9f7

• hosted/cmsis_dap: Early exit on trying to memory access when the setup for the access goes wrong

  dragonmux

  committed
  d3fcb17

• hosted/dap_command: Rewrote the post-request handling for perform_dap_transfer_block_read() to be a little more sane

  dragonmux

  committed
  3fac021

• hosted/dap: Improved the data flows to properly allow the result of a failed partial read up the stack and handling WAIT responses in read as best as we can

  dragonmux

  committed
  b5869ea

• hosted/cmsis_dap: Fixed up all the copyright headers

  dragonmux

  committed
  e975378

• hosted/dap: Fixed the blocks calculation in dap_mem_write_block()

  dragonmux

  committed
  c62dac2

• hosted/dap: Resized the block buffers in dap_mem_{read,write}_block() to exactly fit the max amount transferrable in a go and nothing more

  dragonmux

  committed
  ed0ae20

• hosted/cmsis_dap: Limit the max packet size to 512 bytes to not overflow any buffers anywhere

  dragonmux

  committed
  f46b6d1

• hosted/cmsis_dap: Added a quirk restricting when the ZLP read for Bulk adaptors is done so we don't clobber performance on adaptors that don't need it

  dragonmux

  committed
  9c9d26b