Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdb_packet: add missing <string.h> include #2021

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

xobs
Copy link
Contributor

@xobs xobs commented Dec 15, 2024

gdb_packet.h now calls strlen(), but does not have the include for it. This causes build failures on systems where warnings are treated as errors.

Add #include <string.h> to gdb_packet.h to fix this warning.

Your checklist for this pull request

gdb_packet.h now calls `strlen()`, but does not have the include for it.
This causes build failures on systems where warnings are treated as
errors.

Add `#include <string.h>` to `gdb_packet.h` to fix this warning.

Signed-off-by: Sean Cross <sean@xobs.io>
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch - LGTM, merging. Thank you for the contribution!

@dragonmux dragonmux added the Bug Confirmed bug label Dec 15, 2024
@dragonmux dragonmux added this to the v2.0 release milestone Dec 15, 2024
@dragonmux dragonmux merged commit 90d23db into blackmagic-debug:main Dec 15, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants