Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: build and help #15

Merged
merged 15 commits into from
Oct 14, 2024
Merged

Fix: build and help #15

merged 15 commits into from
Oct 14, 2024

Conversation

dragonmux
Copy link
Member

In this PR we do two things: We fix the build which is broken by an improper project option; and implement better, more discoverable, help care of some companion changes in substrate.

For the first part of this, the project() statement in the top-level meson.build had b_debug as an option specified which is wrong - the option is actually called b_ndebug.

For the second part, we have introduced a new optionsRoot_t to the substrate command line parser types, and implemented a whole lot more help generation machinery which allows it to generate the full help text automatically. This is then backed by companion changes here to make use of the new types and machinery to provide help text generation for cheap while also properly recursing into option set alternations so that the user can get action-specific help as well.

The -h/--help option is now a global option with this, meaning it is allowed to appear at every level of parsing.

@dragonmux dragonmux added this to the v1.0 milestone Oct 14, 2024
@dragonmux dragonmux added Bug Confirmed bug Enhancement General project improvement Core: Build system Something related to the build system Core: Dependency Something related to a dependency labels Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (6ce3273) to head (ea1fa34).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/bmpflash.cxx 0.00% 7 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #15   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1834    1797   -37     
  Branches     572     573    +1     
=====================================
+ Misses      1798    1761   -37     
  Partials      36      36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragonmux dragonmux force-pushed the fix/build-and-help branch 2 times, most recently from 9479c63 to 84180c6 Compare October 14, 2024 10:43
@dragonmux dragonmux requested a review from esden October 14, 2024 10:51
Copy link
Member

@esden esden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esden esden merged commit ea1fa34 into main Oct 14, 2024
58 checks passed
@dragonmux dragonmux deleted the fix/build-and-help branch October 14, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug Core: Build system Something related to the build system Core: Dependency Something related to a dependency Enhancement General project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants