-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: build and help #15
Conversation
…he latest Meson correctly complaining about an unknown option
…ptions and provide automatic help string generation context like the usage strign and help footer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 1834 1797 -37
Branches 572 573 +1
=====================================
+ Misses 1798 1761 -37
Partials 36 36 ☔ View full report in Codecov by Sentry. |
9479c63
to
84180c6
Compare
84180c6
to
c7106af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR we do two things: We fix the build which is broken by an improper project option; and implement better, more discoverable, help care of some companion changes in substrate.
For the first part of this, the
project()
statement in the top-level meson.build hadb_debug
as an option specified which is wrong - the option is actually calledb_ndebug
.For the second part, we have introduced a new optionsRoot_t to the substrate command line parser types, and implemented a whole lot more help generation machinery which allows it to generate the full help text automatically. This is then backed by companion changes here to make use of the new types and machinery to provide help text generation for cheap while also properly recursing into option set alternations so that the user can get action-specific help as well.
The
-h
/--help
option is now a global option with this, meaning it is allowed to appear at every level of parsing.